chore(memory): should generate a new id when an empty string or zero number are given

src/adapter/builtin/memory-adapter.js

@@ -92,7 +92,9 @@ export class MemoryAdapter extends Adapter {
         modelName,
       );
     let idValue = modelData[pkPropName];
-    if (idValue == null) idValue = this._genNextIdValue(modelName, pkPropName);
+    if (idValue == null || idValue === '' || idValue === 0) {
+      idValue = this._genNextIdValue(modelName, pkPropName);
+    }
 
     const table = this._getTableOrCreate(modelName);
     if (table.has(idValue))
@@ -168,7 +170,9 @@ export class MemoryAdapter extends Adapter {
         modelName,
       );
     let idValue = modelData[pkPropName];
-    if (idValue == null) idValue = this._genNextIdValue(modelName, pkPropName);
+    if (idValue == null || idValue === '' || idValue === 0) {
+      idValue = this._genNextIdValue(modelName, pkPropName);
+    }
 
     const table = this._getTableOrCreate(modelName);
     modelData = cloneDeep(modelData);

src/adapter/builtin/memory-adapter.spec.js

@@ -187,6 +187,64 @@ describe('MemoryAdapter', function () {
       expect(tableData).to.be.eql({...input, [DEF_PK]: idValue});
     });
 
+    it('generates a new identifier when a value of a primary key is an empty string', async function () {
+      const schema = new Schema();
+      schema.defineDatasource({
+        name: 'memory',
+        adapter: 'memory',
+      });
+      schema.defineModel({
+        name: 'model',
+        datasource: 'memory',
+        properties: {
+          foo: DataType.STRING,
+          bar: DataType.NUMBER,
+        },
+      });
+      const adapter = new MemoryAdapter(schema.container, {});
+      const input = {
+        [DEF_PK]: '',
+        foo: 'string',
+        bar: 10,
+      };
+      const created = await adapter.create('model', input);
+      const idValue = created[DEF_PK];
+      expect(idValue).to.be.not.eq('');
+      expect(created).to.be.eql({...input, [DEF_PK]: idValue});
+      const table = adapter._getTableOrCreate('model');
+      const tableData = table.get(idValue);
+      expect(tableData).to.be.eql({...input, [DEF_PK]: idValue});
+    });
+
+    it('generates a new identifier when a value of a primary key is zero', async function () {
+      const schema = new Schema();
+      schema.defineDatasource({
+        name: 'memory',
+        adapter: 'memory',
+      });
+      schema.defineModel({
+        name: 'model',
+        datasource: 'memory',
+        properties: {
+          foo: DataType.STRING,
+          bar: DataType.NUMBER,
+        },
+      });
+      const adapter = new MemoryAdapter(schema.container, {});
+      const input = {
+        [DEF_PK]: 0,
+        foo: 'string',
+        bar: 10,
+      };
+      const created = await adapter.create('model', input);
+      const idValue = created[DEF_PK];
+      expect(idValue).to.be.not.eq(0);
+      expect(created).to.be.eql({...input, [DEF_PK]: idValue});
+      const table = adapter._getTableOrCreate('model');
+      const tableData = table.get(idValue);
+      expect(tableData).to.be.eql({...input, [DEF_PK]: idValue});
+    });
+
     it('generates a new identifier for a primary key of a "number" type', async function () {
       const schema = new Schema();
       schema.defineDatasource({
@@ -1214,6 +1272,64 @@ describe('MemoryAdapter', function () {
       expect(tableData).to.be.eql({...input, [DEF_PK]: idValue});
     });
 
+    it('generates a new identifier when a value of a primary key is an empty string', async function () {
+      const schema = new Schema();
+      schema.defineDatasource({
+        name: 'memory',
+        adapter: 'memory',
+      });
+      schema.defineModel({
+        name: 'model',
+        datasource: 'memory',
+        properties: {
+          foo: DataType.STRING,
+          bar: DataType.NUMBER,
+        },
+      });
+      const adapter = new MemoryAdapter(schema.container, {});
+      const input = {
+        [DEF_PK]: '',
+        foo: 'string',
+        bar: 10,
+      };
+      const created = await adapter.replaceOrCreate('model', input);
+      const idValue = created[DEF_PK];
+      expect(idValue).to.be.not.eq('');
+      expect(created).to.be.eql({...input, [DEF_PK]: idValue});
+      const table = adapter._getTableOrCreate('model');
+      const tableData = table.get(idValue);
+      expect(tableData).to.be.eql({...input, [DEF_PK]: idValue});
+    });
+
+    it('generates a new identifier when a value of a primary key is zero', async function () {
+      const schema = new Schema();
+      schema.defineDatasource({
+        name: 'memory',
+        adapter: 'memory',
+      });
+      schema.defineModel({
+        name: 'model',
+        datasource: 'memory',
+        properties: {
+          foo: DataType.STRING,
+          bar: DataType.NUMBER,
+        },
+      });
+      const adapter = new MemoryAdapter(schema.container, {});
+      const input = {
+        [DEF_PK]: 0,
+        foo: 'string',
+        bar: 10,
+      };
+      const created = await adapter.replaceOrCreate('model', input);
+      const idValue = created[DEF_PK];
+      expect(idValue).to.be.not.eq(0);
+      expect(created).to.be.eql({...input, [DEF_PK]: idValue});
+      const table = adapter._getTableOrCreate('model');
+      const tableData = table.get(idValue);
+      expect(tableData).to.be.eql({...input, [DEF_PK]: idValue});
+    });
+
     it('generates a new identifier for a primary key of a "number" type', async function () {
       const schema = new Schema();
       schema.defineDatasource({